-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): apps that use token-aware-stringify are construct-instantiation-order-dependent #31470
Conversation
…endent-logical-IDs
…endent-logical-IDs
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31345.
Reason for this change
Any stringified value containing an intrinsic will use a custom resource to resolve this value at deploy time.
Today, this custom resource's logical ID will take the form
'CDKJsonStringify<number>'
,where is a counter incremented for each stringified value. This results in resource replacement updates for the custom resource when the order of construct instantiation is changed, like changing this:
to:
This only happens if
SomeStack
stringifies a token, which some CDK constructs will do automatically. These resource replacements won't affect customer infrastructure, but customers using a common setup as in #31345 will see diffs on the same application in different environments, which violates the repeatability promise of CDK.Description of changes
Generate a unique identifier from the token's value instead of a counter. This makes this logical ID no longer instantiation-order dependent.
This will cause diffs when upgrading.
Description of how you validated changes
Unit, integration, and manual tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license