fix(cognito-identitypool): refactor authentication providers #31482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The authentication providers and their logic in this module have bad code smells, and thus, we have refactored them to bring the module more in line with CDK standards and best practices.
Description of changes
deprecated
tag, as the service was deprecated back in 2017.IdentityPoolAuthenticationProvider
, as they were incredibly similar aside from slight differences in docstrings and nomenclature.IdentityPoolProviders
andIdentityPoolAuthenticationProviders
interfaces have been merged, as there did not seem to be a reason to keep them separate, aside from differentiating third-party and internal providers.Description of how you validated changes
Unit tests and integration tests have been tweaked only as necessary to confirm these changes. Since they all still pass or show no need to be updated, we can confirm that this refactor does not affect them.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license