chore(rds): deprecate aurora mysql version 1 for mysql 5.6 #31551

go-to-k · 2024-09-25T08:11:04Z

Reason for this change

Aurora MySQL version 1 for MySQL 5.6 is deprecated now.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.11Updates.html

Description of changes

Deprecated the version and no longer use the version in integ tests.

Description of how you validated changes

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

go-to-k · 2024-09-25T08:13:34Z

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-dual.ts

@@ -19,7 +19,7 @@ const instanceProps = {
  isFromLegacyInstanceProps: true,
 };
 new rds.DatabaseCluster(stack, 'DualstackCluster', {
-  engine: rds.DatabaseClusterEngine.auroraMysql({ version: rds.AuroraMysqlEngineVersion.VER_3_02_0 }),


VER_3_02_0 is deprecated.

Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.

Cannot find version 8.0.mysql_aurora.3.02.0 for aurora-mysql

go-to-k · 2024-09-25T08:14:40Z

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-s3.mysql-8.ts

@@ -13,7 +14,7 @@ const importExportBucket = new s3.Bucket(stack, 'ImportExportBucket', {

 new rds.DatabaseCluster(stack, 'Database', {
  engine: rds.DatabaseClusterEngine.auroraMysql({
-    version: rds.AuroraMysqlEngineVersion.VER_3_01_0,


VER_3_01_0 is deprecated.

Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.

Cannot find version 8.0.mysql_aurora.3.01.0 for aurora-mysql

go-to-k · 2024-09-25T08:15:32Z

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.rolling-instance-updates.ts

      instances: 3,
      instanceProps: {
-        instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.SMALL),


SMALL cannot be used for Aurora V3, CFn fails with the message:

RDS does not support creating a DB instance with the following combination: DBInstanceClass=db.t3.small, Engine=aurora-mysql, EngineVersion=8.0.mysql_aurora.3.07.1, LicenseModel=general-public-license. For supported combinations of instance class and database engine version, see the documentation.

go-to-k · 2024-09-25T08:17:06Z

packages/aws-cdk-lib/aws-appsync/test/appsync-rds.test.ts

@@ -33,7 +33,7 @@ describe('Rds Data Source configuration', () => {
      username: 'clusteradmin',
    });
    serverlessCluster = new ServerlessCluster(stack, 'AuroraCluster', {
-      engine: DatabaseClusterEngine.auroraMysql({ version: AuroraMysqlEngineVersion.VER_2_07_1 }),


VER_2_07_1 is deprecated.

go-to-k · 2024-09-25T08:20:13Z

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.rolling-instance-updates.ts

@@ -17,10 +17,12 @@ class RollingInstanceUpdateTestStack extends cdk.Stack {
    });

    new rds.DatabaseCluster(this, 'DatabaseCluster', {
-      engine: rds.DatabaseClusterEngine.AURORA,


Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.

Engine version not found: oscar/null

go-to-k · 2024-09-25T08:23:59Z

packages/aws-cdk-lib/aws-rds/test/cluster-engine.test.ts

-      version: AuroraPostgresEngineVersion.VER_11_6,
+      version: AuroraPostgresEngineVersion.VER_16_3,
    });

    // WHEN
    const family = engine.parameterGroupFamily;

    // THEN
-    expect(family).toEqual('aurora-postgresql11');


While I'm at it: VER_11_6 for PostgreSQL is deprecated.

go-to-k · 2024-09-25T08:24:29Z

packages/aws-cdk-lib/aws-rds/test/cluster-engine.test.ts

@@ -115,8 +116,8 @@ describe('cluster engine', () => {
  test('supported log types', () => {
    const mysqlLogTypes = ['error', 'general', 'slowquery', 'audit'];
    expect(DatabaseClusterEngine.aurora({ version: AuroraEngineVersion.VER_1_22_2 }).supportedLogTypes).toEqual(mysqlLogTypes);
-    expect(DatabaseClusterEngine.auroraMysql({ version: AuroraMysqlEngineVersion.VER_2_08_1 }).supportedLogTypes).toEqual(mysqlLogTypes);
-    expect(DatabaseClusterEngine.auroraPostgres({ version: AuroraPostgresEngineVersion.VER_9_6_9 }).supportedLogTypes).toEqual(['postgresql']);


While I'm at it: VER_9_6_9 for PostgreSQL is deprecated.

go-to-k · 2024-09-25T08:26:03Z

packages/aws-cdk-lib/aws-rds/test/serverless-cluster.test.ts

    new ServerlessCluster(stack, 'Database', {
-      engine: DatabaseClusterEngine.AURORA,
+      engine: DatabaseClusterEngine.AURORA_POSTGRESQL,
      parameterGroup: ParameterGroup.fromParameterGroupName(stack, 'ParameterGroup', 'default.aurora-postgresql11'),
    });


Used AURORA_POSTGRESQL because the 'default.aurora-postgresql11' is specified at parameterGroup.

GavinZZ

Nice, thanks for updating!

mergify · 2024-10-24T21:48:29Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-10-24T21:52:22Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

mergify · 2024-10-24T23:52:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-10-25T00:58:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: ad6124c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-10-25T00:58:49Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-10-25T00:59:06Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

chore(rds): deprecate aurora mysql version 1 for mysql 5.6

6adfc6f

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 25, 2024

aws-cdk-automation requested a review from a team September 25, 2024 08:11

Merge branch 'main' into aurora-mysql-v1-deprecate

caac74f

go-to-k commented Sep 25, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 25, 2024

GavinZZ previously approved these changes Oct 24, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 24, 2024

Merge branch 'main' into aurora-mysql-v1-deprecate

d6b38ee

GavinZZ approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'main' into aurora-mysql-v1-deprecate

ad6124c

mergify bot merged commit 84d71a4 into aws:main Oct 25, 2024
9 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(rds): deprecate aurora mysql version 1 for mysql 5.6 #31551

chore(rds): deprecate aurora mysql version 1 for mysql 5.6 #31551

go-to-k commented Sep 25, 2024

go-to-k Sep 25, 2024 •

edited

Loading

go-to-k Sep 25, 2024 •

edited

Loading

go-to-k Sep 25, 2024

go-to-k Sep 25, 2024

go-to-k Sep 25, 2024

go-to-k Sep 25, 2024

go-to-k Sep 25, 2024

go-to-k Sep 25, 2024

GavinZZ left a comment

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

aws-cdk-automation commented Oct 25, 2024

mergify bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

chore(rds): deprecate aurora mysql version 1 for mysql 5.6 #31551

chore(rds): deprecate aurora mysql version 1 for mysql 5.6 #31551

Conversation

go-to-k commented Sep 25, 2024

Reason for this change

Description of changes

Description of how you validated changes

Checklist

go-to-k Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

go-to-k Sep 25, 2024

Choose a reason for hiding this comment

GavinZZ left a comment

Choose a reason for hiding this comment

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

aws-cdk-automation commented Oct 25, 2024

AWS CodeBuild CI Report

mergify bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

go-to-k Sep 25, 2024 •

edited

Loading

go-to-k Sep 25, 2024 •

edited

Loading