-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-destinations): support Lambda async S3 destination #31709
Changes from 1 commit
d5e4614
5975ebf
54a94fe
f666a0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
export * from './event-bridge'; | ||
export * from './lambda'; | ||
export * from './s3'; | ||
export * from './sns'; | ||
export * from './sqs'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import { Construct } from 'constructs'; | ||
import * as lambda from '../../aws-lambda'; | ||
import * as s3 from '../../aws-s3'; | ||
|
||
/** | ||
* Use a S3 bucket as a Lambda destination | ||
*/ | ||
export class S3Destination implements lambda.IDestination { | ||
constructor(private readonly bucket: s3.IBucket) { | ||
} | ||
|
||
/** | ||
* Returns a destination configuration | ||
*/ | ||
public bind(_scope: Construct, fn: lambda.IFunction, _options?: lambda.DestinationOptions): lambda.DestinationConfig { | ||
// grant read and putObject permissions | ||
this.bucket.grantRead(fn); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I check other destinations and they only need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a cross region check that needs to be done to block cross region bucket setup. Since an S3 arn doesn't have region in the arn format, we have to find the region using a headBucket call (as listed in the s3 documentation). This call needs listBucket permission. That's why read permission is needed. For other destinations, the destination region is in the arn itself. |
||
this.bucket.grantPut(fn); | ||
|
||
return { | ||
destination: this.bucket.bucketArn, | ||
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to run the tests successfully yet. Tomorrow, the service deployment will reach DUB, and I'll run the test there. Then I'll update the commit message and the integration test snapshot.
Please review the other changes until then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test snapshot in a new commit