chore(scheduler-alpha): unit test schedule with Lambda version as target #31872
Conversation
aws-cdk-automation
added
the
pr/needs-maintainer-review
| const lambdaVersion = new lambda.Version(stack, 'MyLambdaVersion', { | ||
| lambda: func, | ||
| }); | ||
| const lambdaTarget = new LambdaInvoke(lambdaVersion, {}); |
There was a problem hiding this comment.
nothing to do with your PR, but since LambdaInvoke can be valid with no properties, we should allow the second field to be optional so we can write LambdaInvoke(lambdaVersion). As simple as:
constructor(
func: lambda.IFunction,
props: ScheduleTargetBaseProps = {},
) {
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Tracking #31785.
Reason for this change
Missing this test case.
Description of changes
Adding a unit test to verify
Scheduleworks with Lambda Version and correct permissions are added.Description of how you validated changes
Unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license