chore: remove trailing space in MD for stability banner #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trailing space that was created when inserting an empty line in the banner's message was very hsotile to manually editing the file with an editor configured to prune trailing white space on save. Added a `trimRight()` call to remove any trailing whitespace, so that the banner never includes trailing whitespace, making the files nicer to otherwise edit manually without risking to break pkglint compliance.
ghost
requested a review
from 
eladb
approved these changes
Jul 3, 2019
Kaixiang-AWS
pushed a commit
to Kaixiang-AWS/aws-cdk
that referenced
this pull request
Jul 3, 2019
The trailing space that was created when inserting an empty line in the banner's message was very hsotile to manually editing the file with an editor configured to prune trailing white space on save. Added a `trimRight()` call to remove any trailing whitespace, so that the banner never includes trailing whitespace, making the files nicer to otherwise edit manually without risking to break pkglint compliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing space that was created when inserting an empty line in the
banner's message was very hsotile to manually editing the file with an
editor configured to prune trailing white space on save.
Added a
trimRight()call to remove any trailing whitespace, so thatthe banner never includes trailing whitespace, making the files nicer
to otherwise edit manually without risking to break pkglint compliance.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license