Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix some return types #3192

Merged
merged 5 commits into from
Jul 4, 2019
Merged

fix(core): fix some return types #3192

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbc1ef3
fix(core): fix return type of Stack.availabilityZones
RomainMuller Jul 3, 2019
ec563c6
Merge branch 'master' into rmuller/fix-return-type
RomainMuller Jul 3, 2019
b37d290
show api compatibility diagnostic ignore keys
RomainMuller Jul 3, 2019
b54c6de
fix a couple more return types & change an internal method name
RomainMuller Jul 3, 2019
05c1d7a
Whitelist acceptable rbeaking changes
RomainMuller Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/core/lib/stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ export class Stack extends Construct implements ITaggable {
* reports them as missing, and let the CLI resolve them by calling EC2
* `DescribeAvailabilityZones` on the target environment.
*/
public get availabilityZones() {
public get availabilityZones(): string[] {
// if account/region are tokens, we can't obtain AZs through the context
// provider, so we fallback to use Fn::GetAZs. the current lowest common
// denominator is 2 AZs across all AWS regions.
Expand Down