chore(cli): add image to gc docs and document race condition #31925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
the
pr/needs-maintainer-review
HBobertz
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Wait shouldn't these be diamonds if it's a decision tree/flowchart?
There was a problem hiding this comment.
personally, i dont think i should be crucified for exact syntax -- unless you are saying that the shapes I am using make the diagram confusing
rix0rrr
reviewed
Oct 29, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Oct 29, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be contentious given that we don't do photos in most places but afaik we do not replicate the CLI docs on the CDK docs site so it may be safe (as it renders correctly on github).
Documents garbage collection algorithm via diagram and details potentail race condition with
REVIEW_IN_PROGRESSstacks.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license