Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): delete noncurrent versions after 30 days #31949

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

kaizencc
Copy link
Contributor

CDK assets in the bootstrap bucket are content-addressed and immutable so we never naturally create noncurrent versions.
However, with the introduction of the cdk gc command, we now have the capacity to delete unused objects in the bucket. Because the bucket is versioned by default, the delete command actually just replaces the object with a new dummy version (thus the deleted object becomes noncurrent).

Now that noncurrent objects can happen, if one utilizes cdk gc, we are updating the bootstrap template to retain them for 30 days rather than 365 days.

Update to bootstrap version 24 to use this new lifecycle policy in conjunction with cdk gc.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2024 16:23
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 30, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 30, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 30, 2024 16:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b1d8a8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 579041e into main Oct 30, 2024
11 of 12 checks passed
Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the conroy/bootstrapupdate branch October 30, 2024 17:28
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants