Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump jsii #31977

Merged
merged 6 commits into from
Nov 4, 2024
Merged

chore: bump jsii #31977

merged 6 commits into from
Nov 4, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 1, 2024

This includes a bugfix that produces an error when optional properties are not declared in an abstract class.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This includes a bugfix that produces an error when optional properties
are not declared in an abstract class.
@rix0rrr rix0rrr requested a review from a team November 1, 2024 12:39
@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2024 12:39
@github-actions github-actions bot added the p2 label Nov 1, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 1, 2024
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you bump to 5.5 you also need to bump typescript

Or you kick off a release for 5.4 - we had the feature backported.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4191c63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7e2e752 into main Nov 4, 2024
12 checks passed
@mergify mergify bot deleted the huijbers/bump-jsii branch November 4, 2024 13:22
Copy link

github-actions bot commented Nov 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants