chore(pipes-targets): remove dependency with pipes-sources #31986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
distinguished-contributor
msambol
commented
Nov 1, 2024
| @@ -89,8 +89,7 @@ | |||
| "aws-cdk-lib": "0.0.0", | |||
| "constructs": "^10.0.0", | |||
| "@aws-cdk/aws-pipes-alpha": "0.0.0", | |||
| "@aws-cdk/integ-tests-alpha": "0.0.0", | |||
| "@aws-cdk/aws-pipes-sources-alpha": "0.0.0" | |||
| "@aws-cdk/integ-tests-alpha": "0.0.0" | |||
There was a problem hiding this comment.
this is the main reason for this PR, to remove @aws-cdk/aws-pipes-sources-alpha here.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
moelasmar
approved these changes
Nov 2, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the integration test cases for both pipes-sources and pipes-targets modules to add comments explained why we use TestTarget, and TestSource instead of using real classes, and this to avoid the circular dependencies, as we need to depend on each module on the other so we can implement these test cases.
These Test classes should be replaced before graduating the pipes alpha modules.