-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): instance support passing IAM instance profile #32073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I can't believe we don't support instance profile until now.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@mergify update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@GavinZZ thanks for your review. I dont know why CodeQL stuck at this snippet now part = `"${part.replace(/"/g, '\\"')}"`; Can confirm this line exists in other generated integ test snapshot. |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I'll reach out internally to see what the CodeCov issue is. |
@phuhung273 I synced with my team and there's some issue with a flaky test in the Code coverage test suite. We're working on a fix, please wait patiently and will update you soon. |
Thanks so much @GavinZZ, please take your time |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32073 +/- ##
==========================================
+ Coverage 78.36% 78.41% +0.04%
==========================================
Files 105 106 +1
Lines 7170 7208 +38
Branches 1315 1323 +8
==========================================
+ Hits 5619 5652 +33
- Misses 1364 1369 +5
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #8348
Reason for this change
Description of changes
ec2.Instance
supportinstanceProfile
paramDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license