Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): add @deprecated tag to python3.8 #32162

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Nov 17, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Updated according to this document.

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 17, 2024 08:07
@github-actions github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Nov 17, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f4f8abc). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32162   +/-   ##
=======================================
  Coverage        ?   77.19%           
=======================================
  Files           ?      105           
  Lines           ?     7164           
  Branches        ?     1311           
=======================================
  Hits            ?     5530           
  Misses          ?     1454           
  Partials        ?      180           
Flag Coverage Δ
suite.unit 77.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdnakt
Copy link
Contributor Author

kdnakt commented Nov 17, 2024

Exemption Request: this pr updates only documentation comment, so no changes for the test.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 17, 2024
gracelu0
gracelu0 previously approved these changes Nov 27, 2024
@gracelu0 gracelu0 added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes labels Nov 27, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 27, 2024 00:14

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ
Copy link
Contributor

GavinZZ commented Dec 12, 2024

@mergify update

Copy link
Contributor

mergify bot commented Dec 12, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify mergify bot dismissed gracelu0’s stale review December 13, 2024 23:49

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2295f3c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 14, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 14, 2024
Copy link
Contributor

mergify bot commented Dec 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 27619cc into aws:main Dec 14, 2024
20 of 22 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants