-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): support observability for ESM ( DDB, Kinesis, SQS) #32204
Conversation
also the build failed with following error
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32204 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Lambda is introducing a new property in Event Sources named
MetricsConfig
to get enhanced metrics for user's event source that captures each stage of processing. Through this metrics customer can track flow of events through their EDA pipelines.This feature is currently supported for
DynamoDB
,Kinesis
andSQS
event sources only.Description of changes
This new property can be opted in by setting the
MetricsConfig
field while creating event sources. The example of opting forMetricsConfig
for dynamoDB event is shown below:Today there is only 1 metric type: EventCount. The
metrics
array can be either one element withEventCount
or an empty array. More configuration support will be available in futureDescription of how you validated changes
Have added unit test and integration test to validate the implementation
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license