feat(ecs): support container version consistency #32225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
repeat-contributor
isker
force-pushed
the
version-consistency
branch
from
63311e2 to
f077a3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32225 +/- ##
=======================================
Coverage 81.37% 81.37%
=======================================
Files 222 222
Lines 13693 13693
Branches 2412 2412
=======================================
Hits 11143 11143
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
isker
force-pushed
the
version-consistency
branch
2 times, most recently
from
e4d61ca to
1255057
Compare
aws-cdk-automation
added
the
pr/needs-community-review
isker
force-pushed
the
version-consistency
branch
from
1255057 to
23808f7
Compare
|
@iliapolo I'm not sure why you updated the branch, but it seems that the resulting CodeBuild CI job hanged or something, the GitHub check is stuck in pending. |
mazyu36
suggested changes
Jan 6, 2025
...ramework-integ/test/aws-ecs/test/base/integ.task-definition-container-version-consistency.ts
Outdated
Show resolved
Hide resolved
isker
force-pushed
the
version-consistency
branch
from
719bb27 to
b28e007
Compare
Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag. Additionally, set a default disabled value if the container image is a CDK asset, for the reasons described in the comments.
isker
force-pushed
the
version-consistency
branch
from
b28e007 to
cb2995a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32202.
Reason for this change
Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag.
Description of changes
Add a simple enabled/disabled enum prop to the construct.
More consequentially, default the prop to disabled (instead of unset) if the container image is a CDK asset, for the reasons described in the comments.
Description of how you validated changes
Unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license