-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cloudfront): prevent WebACL from being created in regions other than us-east-1 #32252
Merged
mergify
merged 12 commits into
aws:main
from
ren-yamanashi:feat-validate-cloud-front-waf-region
Dec 2, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
11e77c4
feat(cloudfront): validate attachWebAclId
ren-yamanashi 8458596
feat(cloudfront): fix validation logic and test
ren-yamanashi 4416463
feat(cloudfront): fix comment
ren-yamanashi 1407e77
delete period
ren-yamanashi 8e16c2e
refactor: validation logic
ren-yamanashi 28698b8
Merge branch 'main' of https://github.com/aws/aws-cdk into feat-valid…
ren-yamanashi 7b0bb76
Merge branch 'main' of https://github.com/aws/aws-cdk into feat-valid…
ren-yamanashi 4a02e21
feat: add validation
ren-yamanashi b27ebf0
Merge branch 'main' into feat-validate-cloud-front-waf-region
mergify[bot] 48d5fce
Merge branch 'main' of https://github.com/aws/aws-cdk into feat-valid…
ren-yamanashi 11a68bf
Merge branch 'main' of https://github.com/aws/aws-cdk into feat-valid…
ren-yamanashi c94ec02
Merge branch 'main' into feat-validate-cloud-front-waf-region
gracelu0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this validation also necessary in the place where the webacl props is being passed?
aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts
Line 342 in 28698b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mazyu36
Thank you very much. As you pointed out, validation was needed, so we have modified it!
(I have modified the policy to provide a validation method in the private method.)
4a02e21