Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aspects): set priorities for existing aspects in CDK #32333

Merged
merged 80 commits into from
Dec 2, 2024

Conversation

sumupitchayan
Copy link
Contributor

Follow-up to #32097

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

sumupitchayan and others added 30 commits November 11, 2024 14:45
…t tests to aspect.test.ts

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…t strings

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…last invoked aspect on a node

Signed-off-by: Sumu <sumughan@amazon.com>
…flag is enabled by default now

Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title chore: set priorities for existing aspects in CDK chore(aspects): set priorities for existing aspects in CDK Nov 29, 2024
@github-actions github-actions bot added the p2 label Nov 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2024 16:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 29, 2024
Signed-off-by: Sumu <sumughan@amazon.com>
Base automatically changed from sumughan/priority-ordered-aspects to main November 29, 2024 17:33
@sumupitchayan sumupitchayan marked this pull request as ready for review November 29, 2024 19:22
@sumupitchayan sumupitchayan requested a review from a team as a code owner November 29, 2024 19:22
Signed-off-by: Sumu <sumughan@amazon.com>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (20edc7f) to head (f5c7638).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32333      +/-   ##
==========================================
+ Coverage   78.48%   78.50%   +0.01%     
==========================================
  Files         106      106              
  Lines        7201     7201              
  Branches     1321     1321              
==========================================
+ Hits         5652     5653       +1     
+ Misses       1362     1361       -1     
  Partials      187      187              
Flag Coverage Δ
suite.unit 78.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.50% <ø> (+0.01%) ⬆️

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f5c7638
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f091714 into main Dec 2, 2024
17 checks passed
@mergify mergify bot deleted the sumughan/aspects/set-default-prios branch December 2, 2024 18:08
Copy link

github-actions bot commented Dec 2, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants