chore(elasticloadbalancingv2): add ssl policy TLS13_12 #32377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Hi Teams, aws-cdk-lib: aws-elasticloadbalancingv2/lib/shared/enums.ts:109:3 - error JSII1004: Value 'ELBSecurityPolicy-TLS13-1-2-2021-06' is used for multiple enum values: RECOMMENDED_TLS, TLS13_12 I make a another PR. Which is better. |
1 task
GavinZZ
pushed a commit
that referenced
this pull request
Dec 6, 2024
) ### Issue # (if applicable) Closes #32307 . ### Reason for this change Enum SslPolicy doesn't have a TLS13_12. When I try to add, it was failed caused by the value conflicts with the exiting value `RECOMMENDED_TLS`. But User will be confused. So I add a comment. #32377 (comment) ### Description of changes add comment to doc. ### Description of how you validated changes <!--Have you added any unit tests and/or integration tests?--> ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: MasakiYamanaka <nes-m.yamanaka@nec.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32307 .
Reason for this change
TLS13_12 is not exist in "SslPolicy".
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/describe-ssl-policies.html
Description of changes
added TLS13_12.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license