Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update Command enum #32688

Merged
merged 2 commits into from
Dec 30, 2024
Merged

chore(cli): update Command enum #32688

merged 2 commits into from
Dec 30, 2024

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Dec 30, 2024

This is a stopgap -- Command should eventually be generated but I do not have capability to generate enums or an equivalent type to replace this yet.

I am using Command as an exhaustive list to generate other code blocks; it was not used that way in the past so it hasn't needed to be updated with new commands as they've been added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner December 30, 2024 16:50
@github-actions github-actions bot added the p2 label Dec 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 30, 2024 16:50
@kaizencc kaizencc added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed p2 labels Dec 30, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (2355d1c) to head (bf9fa4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32688      +/-   ##
==========================================
+ Coverage   66.94%   66.96%   +0.01%     
==========================================
  Files         329      329              
  Lines       18651    18660       +9     
  Branches     3256     3256              
==========================================
+ Hits        12486    12495       +9     
  Misses       5838     5838              
  Partials      327      327              
Flag Coverage Δ
suite.unit 66.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <100.00%> (+0.02%) ⬆️
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@github-actions github-actions bot added the p2 label Dec 30, 2024
Copy link
Contributor

mergify bot commented Dec 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bf9fa4a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 82a0c6b into main Dec 30, 2024
18 of 19 checks passed
@mergify mergify bot deleted the conroy/commandenum branch December 30, 2024 17:52
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants