Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(appsync): correct the schema definition for the sample code #32982

Closed
wants to merge 1 commit into from

Conversation

azarboon
Copy link
Contributor

@azarboon azarboon commented Jan 17, 2025

Issue #32889

Closes #32889

Reason for this change

The current sample schema is incorrect and causes stack deployment to fail. As per @samson-keung's instructions, I’ve created this new PR to address the issue.

Description of changes

I modified the sample GraphQL schema so that it is successfully deployed.

Describe any new or updated permissions being added

Description of how you validated changes

I was able to successfully deploy the stack after making the changes I already proposed in the PR.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 07:22
@github-actions github-actions bot added bug This issue is a bug. p2 labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (2b2443d) to head (a84bd52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32982   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         226      226           
  Lines       13768    13768           
  Branches     2416     2416           
=======================================
  Hits        11219    11219           
  Misses       2271     2271           
  Partials      278      278           
Flag Coverage Δ
suite.unit 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.89% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@azarboon
Copy link
Contributor Author

@samson-keung this is the new PR created as per your instructions. Currently, one of the automated checks has failed for an unrelated reason. I believe it might be temporary, as I only made a brief edit to the README file.

Please review and let me know how to proceed.

@samson-keung
Copy link
Contributor

Sorry for making you creating this PR. I thought this would be needed to resolve the CodeCov transient error. Closing this now.

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a84bd52
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants