Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): old setInterval remains and is not cleared in garbage collection #32985

Merged
merged 10 commits into from
Feb 10, 2025

Merge branch 'main' into fix-garbage-collector-timer

9a7daea
Select commit
Loading
Failed to load commit list.
Merged

fix(cli): old setInterval remains and is not cleared in garbage collection #32985

Merge branch 'main' into fix-garbage-collector-timer
9a7daea
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Feb 10, 2025 in 0s

The pull request embarked with main (00430ac) will be merged soon

Required conditions for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge|no-squash|priority-pr)
  • -merged
  • -title~=(WIP|wip)
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-success = collect
    • check-neutral = collect
    • check-skipped = collect

Check-runs and statuses of the embarked pull request #32985:

submit-to-test-pipeline details
auto-approve details
AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv) Build succeeded for project AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQvdetails
Analyze (javascript-typescript) details
Analyze (python) details
CodeQL — No new alerts in code changed by this pull requestdetails
cli-changes details
codecov/patch — 100.00% of diff hit (target 95.00%)details
codecov/patch/packages/aws-cdk — 100.00% of diff hit (target 95.00%)details
codecov/patch/packages/aws-cdk-lib/core — Coverage not affected when comparing 00430ac...9a7daeadetails
codecov/project — 80.92% (+0.00%) compared to 00430acdetails
codecov/project/packages/aws-cdk — 79.74% (+0.00%) compared to 00430acdetails
codecov/project/packages/aws-cdk-lib/core — 82.20% (+0.00%) compared to 00430acdetails
collect details
download-if-workflow-run details
prioritize details
validate-pr details