refactor(cli): CliIoHost is more self contained
#32993
Conversation
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32993/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
mrgrain
force-pushed
the
mrgrain/chore/cli-io-host-levels
branch
from
c10ce7a to
0b7a737
Compare
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
mrgrain
changed the title
CliIoHost is more self contained
mrgrain
force-pushed
the
mrgrain/chore/cli-io-host-levels
branch
from
0b7a737 to
868accd
Compare
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/chore/cli-io-host-levels
branch
from
ef1b4fb to
0e2b414
Compare
| @@ -214,21 +216,25 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n | |||
| }); | |||
|
|
|||
| case 'docs': | |||
| case 'doc': | |||
There was a problem hiding this comment.
no way we just didn't honor doc until just now
There was a problem hiding this comment.
We did not. Maybe I should leave it out 🙈
mrgrain
force-pushed
the
mrgrain/chore/cli-io-host-levels
branch
from
0e2b414 to
43e1313
Compare
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32993 +/- ##
==========================================
- Coverage 81.44% 81.39% -0.06%
==========================================
Files 225 225
Lines 13702 13714 +12
Branches 2404 2411 +7
==========================================
+ Hits 11160 11162 +2
- Misses 2267 2277 +10
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Description of changes
We currently have to maintain a global singleton
CliIoHostuntil we have passed the ioHost through all the layers for logging. Previously the global settings for thisIoHostwere all over the place using setter functions and global variables. This refactor unifies all these APIs on theCliIoHost, through the global instance.We also need the ability to register a different
IoHostthat must be used for reporting. This is the case when a Toolkit integrator provides a custom implemenation.Describe any new or updated permissions being added
no
Description of how you validated changes
Existing and updated test cases.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license