docs(cdk-lib): fix typos #33008

andyu17 · 2025-01-18T04:55:33Z

Issue # (if applicable)

Closes #.

None

Fixed typos in code comments.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

codecov · 2025-01-18T05:12:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (531280f) to head (5c3498c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33008   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14269    14269           
  Branches     2492     2492           
=======================================
  Hits        11558    11558           
  Misses       2425     2425           
  Partials      286      286

Flag	Coverage Δ
suite.unit	`81.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`79.92% <ø> (ø)`
packages/aws-cdk-lib/core	`82.16% <ø> (ø)`

lpizzinidev

Thanks for all the adjustments!
Opening a single PR for all the typos you find should help simplify the job (with a docs(cdk-lib) generic title prefix).

lpizzinidev · 2025-01-18T18:20:26Z

packages/aws-cdk-lib/aws-s3/lib/bucket.ts

@@ -964,7 +964,7 @@ export abstract class BucketBase extends Resource implements IBucket {
   * Function to add required permissions to the destination bucket for cross account
   * replication. These permissions will be added as a resource based policy on the bucket
   * @see https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication-walkthrough-2.html
-   * If owner of the bucket needs to be overriden, set accessControlTransition to true and provide
+   * If owner of the bucket needs to be overridden, set accessControlTransition to true and provide


I see other 5 occurrences of this typo in the project. Can you please adjust those as well?

Thank you, I fix it.

lpizzinidev · 2025-01-22T16:18:55Z

@andyu17 It seems like the linter is complaining

aws-cdk-automation

(This review is outdated)

aws-cdk-automation

(This review is outdated)

Dismissing outdated PRLinter review.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev · 2025-01-28T17:55:31Z

@andyu17 This integration test seems to fail for some reason. Can you try to run it locally?

aaythapa · 2025-02-04T21:32:35Z

@mergify update

mergify · 2025-02-04T21:32:47Z

update

✅ Branch has been successfully updated

aaythapa · 2025-02-07T00:25:04Z

@mergify update

mergify · 2025-02-07T00:25:09Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

aaythapa · 2025-02-07T19:39:53Z

@mergify update

mergify · 2025-02-07T19:40:06Z

update

✅ Branch has been successfully updated

packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/outbound.ts

…untime/outbound.ts

aaythapa · 2025-02-13T22:45:14Z

@mergify update

mergify · 2025-02-13T22:45:21Z

update

✅ Branch has been successfully updated

mergify · 2025-02-13T23:17:34Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-13T23:34:33Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

aaythapa · 2025-02-14T00:45:42Z

@mergify update

mergify · 2025-02-14T00:45:50Z

update

☑️ Nothing to do

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

Pull request has been modified.

mergify · 2025-02-14T01:18:56Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-02-14T01:51:03Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 5c3498c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-14T01:51:22Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-14T01:51:39Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

andyu17 added 2 commits January 18, 2025 13:47

docs(s3): fix typos

a1f0906

docs(s3): fix typos readme

726c2b6

aws-cdk-automation requested a review from a team January 18, 2025 04:55

github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jan 18, 2025

aws-cdk-automation previously requested changes Jan 18, 2025

View reviewed changes

andyu17 changed the title ~~Fix s3 20250118~~ docs(s3): fix typos Jan 18, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 18, 2025

lpizzinidev suggested changes Jan 18, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 18, 2025

andyu17 changed the title ~~docs(s3): fix typos~~ docs(cdk-lib): fix typos Jan 21, 2025

docs(cdk-lib): fix typos

38a0de1

style(ecs): fix indent

be2c1a7

aws-cdk-automation previously requested changes Jan 25, 2025

View reviewed changes

Merge branch 'main' into fix-s3-20250118

544538a

andyu17 requested a review from lpizzinidev January 28, 2025 13:49

github-actions bot mentioned this pull request Feb 1, 2025

Monthly PR metrics report #33266

Closed

Merge branch 'main' into fix-s3-20250118

9fcb84c

Merge branch 'main' into fix-s3-20250118

7e607a3

Merge branch 'main' into fix-s3-20250118

8228ff8

Merge branch 'main' into fix-s3-20250118

383233b

Merge branch 'main' into fix-s3-20250118

81fbef2

aaythapa reviewed Feb 13, 2025

View reviewed changes

packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/outbound.ts Outdated Show resolved Hide resolved

Update packages/aws-cdk-lib/custom-resources/lib/provider-framework/r…

a35c688

…untime/outbound.ts

aaythapa previously approved these changes Feb 13, 2025

View reviewed changes

Merge branch 'main' into fix-s3-20250118

eb6ea70

Merge branch 'main' into fix-s3-20250118

0af5a05

aaythapa approved these changes Feb 14, 2025

View reviewed changes

Merge branch 'main' into fix-s3-20250118

5c3498c

mergify bot merged commit e5e4f9b into aws:main Feb 14, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(cdk-lib): fix typos #33008

docs(cdk-lib): fix typos #33008

andyu17 commented Jan 18, 2025

aws-cdk-automation left a comment

codecov bot commented Jan 18, 2025 •

edited

Loading

lpizzinidev left a comment

lpizzinidev Jan 18, 2025

andyu17 Jan 22, 2025

lpizzinidev commented Jan 22, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

lpizzinidev commented Jan 28, 2025

aaythapa commented Feb 4, 2025

mergify bot commented Feb 4, 2025

aaythapa commented Feb 7, 2025

mergify bot commented Feb 7, 2025

aaythapa commented Feb 7, 2025

mergify bot commented Feb 7, 2025

aaythapa commented Feb 13, 2025

mergify bot commented Feb 13, 2025

mergify bot commented Feb 13, 2025

mergify bot commented Feb 13, 2025

aaythapa commented Feb 14, 2025

mergify bot commented Feb 14, 2025

mergify bot commented Feb 14, 2025

aws-cdk-automation commented Feb 14, 2025

mergify bot commented Feb 14, 2025

github-actions bot commented Feb 14, 2025

docs(cdk-lib): fix typos #33008

docs(cdk-lib): fix typos #33008

Conversation

andyu17 commented Jan 18, 2025

Issue # (if applicable)

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 18, 2025 • edited Loading

Codecov Report

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Jan 18, 2025

Choose a reason for hiding this comment

andyu17 Jan 22, 2025

Choose a reason for hiding this comment

lpizzinidev commented Jan 22, 2025 • edited Loading

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

lpizzinidev commented Jan 28, 2025

aaythapa commented Feb 4, 2025

mergify bot commented Feb 4, 2025

✅ Branch has been successfully updated

aaythapa commented Feb 7, 2025

mergify bot commented Feb 7, 2025

❌ Mergify doesn't have permission to update

aaythapa commented Feb 7, 2025

mergify bot commented Feb 7, 2025

✅ Branch has been successfully updated

aaythapa commented Feb 13, 2025

mergify bot commented Feb 13, 2025

✅ Branch has been successfully updated

mergify bot commented Feb 13, 2025

mergify bot commented Feb 13, 2025

aaythapa commented Feb 14, 2025

mergify bot commented Feb 14, 2025

☑️ Nothing to do

mergify bot commented Feb 14, 2025

aws-cdk-automation commented Feb 14, 2025

AWS CodeBuild CI Report

mergify bot commented Feb 14, 2025

github-actions bot commented Feb 14, 2025

codecov bot commented Jan 18, 2025 •

edited

Loading

lpizzinidev commented Jan 22, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading