Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fetchOpenPullRequests method to pass organisation in github action workflow for prioritization #33073

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

godwingrs22
Copy link
Member

@godwingrs22 godwingrs22 commented Jan 22, 2025

Issue # (if applicable)

N/A

Reason for this change

PR Prioritization R5 Check and PR Prioritization R2 Check github action workflow is failing since it is not able to call the graphql api with the repo owner.

GraphqlResponseError: Request failed due to following response errors:
 - Variable $owner of type String! was provided invalid value
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:6669:[13](https://github.com/aws/aws-cdk/actions/runs/12902208172/job/36014470718#step:3:14)
Error: Unhandled error: GraphqlResponseError: Request failed due to following response errors:
 - Variable $owner of type String! was provided invalid value

Description of changes

R2 and R5 prioritization uses fetchOpenPullRequests method that needs to be updated with organisation parameter and query as the aws-cdk repo is under aws org.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Ran unit test and tested in local repo.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2025 20:53
@github-actions github-actions bot added the p2 label Jan 22, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@godwingrs22 godwingrs22 added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 22, 2025
@godwingrs22
Copy link
Member Author

Exemption Request: The change is on the github action script and doesn't need a integ test.

@godwingrs22 godwingrs22 changed the title fix: update fetchOpenPullRequests method to pass organisation fix: update fetchOpenPullRequests method to pass organisation in github action workflow for prioritization Jan 22, 2025
@godwingrs22 godwingrs22 marked this pull request as ready for review January 22, 2025 21:03
@godwingrs22 godwingrs22 self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (d6e3c61) to head (a44d3ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33073   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         224      224           
  Lines       13762    13762           
  Branches     2414     2414           
=======================================
  Hits        11220    11220           
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.93% <ø> (ø)
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@gracelu0 gracelu0 added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jan 22, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 22, 2025 21:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@godwingrs22 godwingrs22 removed their assignment Jan 22, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a44d3ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 066cd4f into aws:main Jan 22, 2025
59 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants