chore(eks-v2): refactor kubectlProvider #33087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33087 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 232 232
Lines 14111 14111
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2431 2431
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -155,11 +109,12 @@ export interface ICluster extends IResource, ec2.IConnectable { | |||
| readonly ipFamily?: IpFamily; | |||
|
|
|||
| /** | |||
| * An AWS Lambda layer that contains the `aws` CLI. | |||
| * Optionsl for creating the kubectl provider - a lambda function that executes `kubectl` and `helm` | |||
There was a problem hiding this comment.
| * Optionsl for creating the kubectl provider - a lambda function that executes `kubectl` and `helm` | |
| * Options for creating the kubectl provider - a lambda function that executes `kubectl` and `helm` |
I see a few more places with the same docstring typo to be fixed, won't add a comment for each one 😅
| vpcSubnets: cluster.kubectlPrivateSubnets ? { subnets: cluster.kubectlPrivateSubnets } : undefined, | ||
| securityGroups: cluster.kubectlPrivateSubnets && cluster.kubectlSecurityGroup ? [cluster.kubectlSecurityGroup] : undefined, | ||
| vpc: props.cluster.vpc, | ||
| // vpcSubnets, |
There was a problem hiding this comment.
should this be uncommented or removed?
There was a problem hiding this comment.
nice catch! This should be uncommented.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@Mergifyio refresh |
✅ Pull request refreshed |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Group
kubectlrelated properties together and make the cluster construct easier to use.Description of changes
kubectlrelated properties into an interfacekubectlProviderOptionskubectlProviderOptionsis not set, kubectl provider custom resource will not be created.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit tests passed. Integration tests will be added in next PR.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license