fix(s3): fail early with bad notification filters

[jogold]

Avoid CF deploy time errors when specifying multiple prefixes or suffixes in notification filters.

Closes #3347

---

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[jogold]

Note
The following code:

bucket.addObjectCreatedNotification(
  new notifications.LambdaDestination(notifierFn),
  { prefix: 'a/', suffix: '.txt' }
)

is currently equivalent to:

bucket.addObjectCreatedNotification(
  new notifications.LambdaDestination(notifierFn),
  { prefix: 'a/' }, { suffix: '.txt' }
)

meaning that with the current implementation it makes no sense to have addObjectCreatedNotification() accept ...filters: NotificationKeyFilter[] as last argument.

Should be addressed in a future version to offer a better API allowing something like that:

bucket.addObjectCreatedNotification( // multiple calls to `addObjectCreatedNotifcation` are needed to achieve this today
  new notifications.LambdaDestination(notifierFn),
  { prefix: 'docs/', suffix: '.pdf' },
  { prefix: 'images/', suffix: '.png' }
)

which is breaking... for v2?

How do you guys track changes that are breaking but that could be considered in a future version?

[eladb]

Created: https://github.com/aws/aws-cdk/issues/3398

[shellscape]

@eladb several years on, this continues to cause developer experience pain. it's worth revisiting.

[eladb]

Agreed, I am just out of the loop at this point :-)