fix(toolkit): avoid EMFILE and preserve mode when zipping #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To preserve file order using `archiver` files must be appended serially either using stream or buffer (appending by file path does not preserve order even when done serially). Appending using buffer seems to be the only way to solve `EMFILE` errors. Call `fs.stat` before appending to preserve mode. Closes aws#3145, Closes aws#3344, Closes aws#3413
eladb
approved these changes
Jul 25, 2019
eladb
reviewed
Jul 25, 2019
| // Append files serially to ensure file order | ||
| for (const file of files) { | ||
| const fullPath = path.join(directory, file); | ||
| const [data, stat] = await Promise.all([fs.readFile(fullPath), fs.stat(fullPath)]); |
There was a problem hiding this comment.
Again... I am concerned about memory usage. Can we throttle this some how? Instead of reading all files at once, can we read them one by one or in batches?
There was a problem hiding this comment.
The files are now read and appended one by one, this line just reads and "stats" in parallel a single file.
There was a problem hiding this comment.
Thanks for fixing this. It is currently crashing our build when zip files are being generated.
This was referenced Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve file order using
archiverfiles must be appended serially either using stream orbuffer (appending by file path does not preserve order even when done serially).
Appending using buffer seems to be the only way to solve
EMFILEerrors.Call
fs.statbefore appending to preserve mode.Closes #3145, Closes #3344, Closes #3413
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license