Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 6, 2025

This turns on Go publishing for the
@aws-cdk/app-staging-synthesizer-alpha package.

This PR should be all that is necessary, given that all other alpha packages are publishing into the same GitHub repo as this one and it already exists. We will monitor during the next release.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This turns on Go publishing for the
`@aws-cdk/app-staging-synthesizer-alpha` package.

This PR *should* be all that is necessary, given that all other alpha
packages are publishing into the same GitHub repo as this one and it
already exists. We will monitor during the next release.
@rix0rrr rix0rrr requested a review from a team May 6, 2025 06:30
@aws-cdk-automation aws-cdk-automation requested a review from a team May 6, 2025 06:31
@github-actions github-actions bot added the p2 label May 6, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 6, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 6, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 6, 2025 06:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.12%. Comparing base (b99f241) to head (b9d42b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34364   +/-   ##
=======================================
  Coverage   84.12%   84.12%           
=======================================
  Files         124      124           
  Lines        7060     7060           
  Branches     1191     1191           
=======================================
  Hits         5939     5939           
  Misses       1009     1009           
  Partials      112      112           
Flag Coverage Δ
suite.unit 84.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 84.12% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9d42b4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 6, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 6, 2025
@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4e3df41 into main May 6, 2025
56 checks passed
@mergify mergify bot deleted the huijbers/enable-appstaging-go branch May 6, 2025 07:06
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants