Skip to content

Conversation

@samson-keung
Copy link
Contributor

Issue # (if applicable)

N/A

Reason for this change

This upgrade is supposed to be done as part of #34362. But the @aws-cdk/cloud-assembly-schema upgrade requires a manual update to the unit test so I am isolating this upgrade to this PR.

v41.2.0 introduced a new line in the manifest file (PR: aws/aws-cdk-cli#184), hence, the unit test was failing.

Description of changes

Upgraded @aws-cdk/cloud-assembly-schema to v41.2.0 and updated unit test.

Describe any new or updated permissions being added

None

Description of how you validated changes

Ran the build locally and no longer see the unit test failing

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 6, 2025 19:05
@github-actions github-actions bot added the p2 label May 6, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 6, 2025
@samson-keung samson-keung requested a review from a team as a code owner May 6, 2025 21:16
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 6, 2025
@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 6, 2025
@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@samson-keung
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 6, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify
Copy link
Contributor

mergify bot commented May 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 088537c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e136f61 into aws:main May 7, 2025
14 of 15 checks passed
@mergify
Copy link
Contributor

mergify bot commented May 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2025
@samson-keung samson-keung deleted the upgrade-assembly-to-41.2 branch May 7, 2025 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants