-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(dynamodb): some grant methods generate incorrect policies. #34575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Exemption Request:
|
Issue
Problem 1
Generated policy by grantStreamRead and grantTableListStreams includes
dynamodb:ListStreamsas action, but stream ARN is specified as resource currently. ListStreams API does not support resource-level permissions, so generated policy will not grant access. Similar issue was fixed in Table v1 by #10631.Problem 2
Generated policy by grantReadData and grantReadWriteData includes
dynamodb:GetRecordsanddynamodb:GetShardIteratoras action, but table ARN is specified as resource currently. Those actions support only stream for resource-level permissions, so generated policy will not grant access to do those 2 actions. Those permissions should be granted by grantStreamRead.Description of changes
dynamodb:GetRecordsanddynamodb:GetShardIteratorfrom grantReadData and grantReadWriteDataChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license