Skip to content

Conversation

@phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #34514

Reason for this change

DockerRunOptions has network param but DockerBuildOptions doesn't

Description of changes

DockerBuildOptions support network param

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Test DockerImage.fromBuild with python-alpha/test/integ.function.custom-build

$ ps aux | grep "docker build"
superch+ 44036  0.1  0.1 1994552 26112 pts/0   Sl+  08:20   0:00 docker build -t cdk-5322298f1d5d198bb67c2885f92ffc76a9e60f4ec4b584a8df116ebc75ebc843 --network default /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/lambda-handler-custom-build

Test PythonLayerVersion with python-alpha/test/integ.function.project

$ ps aux | grep "docker build"
superch+ 76129  100  0.1 1920308 24064 pts/0   Sl+  09:09   0:00 docker build -t cdk-858025f5c9bccadc11d046a66c283180089509773bb117d94236a7e2c03a0295 --platform linux/amd64 --network default --build-arg IMAGE=public.ecr.aws/sam/build-python3.13 /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@phuhung273 phuhung273 requested a review from a team as a code owner June 15, 2025 09:56
@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2025 09:56
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jun 15, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 15, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8b3ccfb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alvazjor alvazjor self-assigned this Aug 27, 2025
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bc333e2 into aws:main Aug 27, 2025
19 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2025
@phuhung273 phuhung273 deleted the docker-build-network branch August 27, 2025 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_lambda_python_alpha: BundlingOptions network parameter is ignored

3 participants