Skip to content

Conversation

@leonmk-aws
Copy link
Contributor

Reason for this change

A new Github action to check for LFS files was added and users without LFS cannot have their PR pass this test if they updated an integ test.

Description of changes

Add instructions on how to check if git lfs is installed, how to install it and fix the problematic files.

Description of how you validated changes

Helped a contributor make the test pass on his PR.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2025 15:24
@github-actions github-actions bot added the p2 label Jun 16, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 16, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 16, 2025
@aemada-aws aemada-aws self-assigned this Jun 18, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9ae9ab9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3d0e68e into aws:main Jun 18, 2025
17 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2025
@leonmk-aws leonmk-aws deleted the update-contributing branch August 21, 2025 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants