Skip to content

Conversation

@phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Jun 20, 2025

Issue # (if applicable)

Closes #21935

Reason for this change

WebSocketStage support accessLogSettings

Description of changes

  • WebSocketStage support accessLogSettings
  • Add default logging format for WebSocket, different from Http

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jun 20, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 22, 2025 02:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2025
@phuhung273 phuhung273 force-pushed the websocket-accesslog branch from 7662595 to 8d53fa9 Compare July 5, 2025 10:16
@phuhung273 phuhung273 force-pushed the websocket-accesslog branch from 8d53fa9 to eb2b528 Compare July 19, 2025 03:36
@phuhung273 phuhung273 changed the title feat(apigatewayv2): WebSocketStage support accessLogSettings, cloudWatchRole, cloudWatchRoleRemovalPolicy feat(apigatewayv2): WebSocketStage support accessLogSettings Jul 19, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb2b528
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Abogical Abogical self-assigned this Nov 3, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done!

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot force-pushed the websocket-accesslog branch from 040e32f to e4fed26 Compare November 3, 2025 16:35
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dad112e into aws:main Nov 3, 2025
19 of 20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2025
@phuhung273 phuhung273 deleted the websocket-accesslog branch November 3, 2025 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(aws-apigatewayv2-alpha): Add properties for specifing access and data logs to HttpApi and WebSocketApi classes

3 participants