-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs(eks): clarify TaintEffect enum usage for AWS vs Kubernetes contexts #34781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Abogical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lint failure. See logs [here](Build Logs).
@aws-cdk/aws-eks-v2-alpha: /codebuild/output/src1131233384/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-eks-v2-alpha/lib/managed-nodegroup.ts
@aws-cdk/aws-eks-v2-alpha: 159:3 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks-v2-alpha: 163:3 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks-v2-alpha: 166:66 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks-v2-alpha: 168:3 error Trailing spaces not allowed no-trailing-spaces
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Related to #34780
Reason for this change
After thorough investigation, the original issue was caused by a misunderstanding of taint effect format differences between AWS EKS API and Kubernetes manifests. The
TaintEffectenum is working correctly as designed for its intended purpose (EKS NodeGroups).Description of changes
Documentation Changes:
TaintEffectenum explaining the format differences between AWS EKS API and Kubernetes manifestsKey findings from investigation:
NO_SCHEDULE,PREFER_NO_SCHEDULE,NO_EXECUTENoSchedule,PreferNoSchedule,NoExecuteWhy the original approach was incorrect:
The
TaintEffectenum cannot be changed because it would break all existing EKS NodeGroup deployments. The enum is correctly designed for AWS EKS API, not for direct Kubernetes manifests.Correct solution for users:
TaintEffectenum for EKS NodeGroups (AWS API format)Describe any new or updated permissions being added
No new or updated IAM permissions are needed for this change.
Description of how you validated changes
Checklist
--
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license