Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 27, 2025

I feel like the term default on a feature flag might be confusing.

Replace with the much more pointed "unconfigured behaves like" naming.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

I feel like the term `default` on a feature flag might be confusing.

Replace with the much more pointed "unconfigured behaves like" naming.
@rix0rrr rix0rrr requested review from a team June 27, 2025 13:45
@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2025 13:46
@github-actions github-actions bot added the p2 label Jun 27, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2025
| ----- | ----- | ----- |
| 1.58.0 | `false` | `true` |
| 2.0.0 | `true` | `true` |
| 2.0.0 | `false` | `true` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this updating documentation to reflect the correct value, or is there a behaviour change?

I don't see a behavioural change in the code but just checking anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that is weird. I'll double check. Thanks for the catch.

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot had a problem deploying to test-pipeline July 2, 2025 13:04 Failure
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3fb933d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 07a8698 into main Jul 2, 2025
17 of 18 checks passed
@mergify mergify bot deleted the huijbers/behaveslike branch July 2, 2025 13:36
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants