-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: update feature flag documentation #34838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I feel like the term `default` on a feature flag might be confusing. Replace with the much more pointed "unconfigured behaves like" naming.
| | ----- | ----- | ----- | | ||
| | 1.58.0 | `false` | `true` | | ||
| | 2.0.0 | `true` | `true` | | ||
| | 2.0.0 | `false` | `true` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this updating documentation to reflect the correct value, or is there a behaviour change?
I don't see a behavioural change in the code but just checking anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that is weird. I'll double check. Thanks for the catch.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
I feel like the term
defaulton a feature flag might be confusing.Replace with the much more pointed "unconfigured behaves like" naming.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license