Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jun 27, 2025

Reason for this change

ECR Public repo allows 1 request/second for un-authenticated pulls and 10 request/second for authenticated pulls.

We try to avoid making requests to any repos by caching the used image as much as possible.
We do this on builds on main as a baseline and restore the cache on PRs. This assumes that most PRs won't add new images and adding new images is rare enough.

Description of changes

Add a cache for docker images.

Describe any new or updated permissions being added

None.

Description of how you validated changes

Run the commands manually.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2025 16:08
@github-actions github-actions bot added the p2 label Jun 27, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 38258be
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 164dc01 into main Jun 27, 2025
18 checks passed
@mergify mergify bot deleted the mrgrain/ci/cache-docker-images branch June 27, 2025 17:32
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants