-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(core): addInfoV2 method for suppressible info Annotations #34872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
Exemption request for integration test / snapshot requirement This change only adds functionality inside the
Given that |
|
I've compared it with the existing |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34871
Reason for this change
Description of changes
This PR adds the following new features to the
Annotationsclass:addInfoV2method - A method to add acknowledgeable info messagesacknowledgeInfomethod - A method to mark specific info messages as acknowledgedThese changes follow the same pattern as the existing warning message functionality (
addWarningV2/acknowledgeWarning), maintaining API consistency.Describe any new or updated permissions being added
This PR does not add any new IAM permissions.
Description of how you validated changes
The following tests were added to validate the functionality:
addInfoV2correctly adds info messagesacknowledgeInfocorrectly marks info messages as acknowledged and they are no longer displayedChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license