fix(aws-pipes-alpha): properly infer if given deadLetterTarget is IQu… #34876
Conversation
…eue or ITopic instead of using instanceof tests. Prevent custom IQueue implementations of not being set as DeadLetterTargets of Pipes.
github-actions
bot
added
beginning-contributor
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'pipes-alpha' instead of 'aws-pipes-alpha'.
❌ Pull requests from `main` branch of a fork cannot be accepted. Please reopen this contribution from another branch on your fork. For more information, see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
|
Comments on closed issues and PRs are hard for our team to see. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 participants
…eue or ITopic instead of using instanceof tests. Prevent custom IQueue implementations of not being set as DeadLetterTargets of Pipes.
Issue # (if applicable)
Closes #34812
Reason for this change
If you create a custom class implementing IQueue or ITopic and try to use it as a DeadLetterTarget of a Pipe DynamoDbStreamSource, it is ignored as the calls to instanceof Queue or Topic fail. Its because IQueue and ITopic are interfaces and not base classes. If I have
class TestQueue implements IQueue {...}, doing(if obj instanceof Queue)will always fail.Description of changes
Instead of testing if its a Queue or Topic with instanceof, since the construct parameters accept IQueue or ITopic, we need to test if the provided object implements IQueue or ITopic.
With the changes provided, as the unit tests show, you can give any object implementing either IQueue or ITopic interfaces and it will be used as a DeadLetterTarget of DynamoDBStream.
Describe any new or updated permissions being added
None.
Description of how you validated changes
All unit tests are passing. I haven't modified any unit test, only added two new that prove that the IQueue or ITopic are used as DeadLetterTarget and we also test that grantPublish or grantSendMessages are appropriately called.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license