Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

Issue # (if applicable)

None

Reason for this change

cloudformation supports for configuring enhanced shard-level monitoring for Kinesis stream.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-kinesis-stream.html#cfn-kinesis-stream-desiredshardlevelmetrics

Description of changes

  • Define ShardLevelMetrics enum
  • Add shardLevelMetrics to StreamProps

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2025 05:05
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jul 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@badmintoncryer badmintoncryer force-pushed the desired-shard-metrics branch from 74eeb94 to 6e4a424 Compare July 13, 2025 15:29
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2025 15:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

… # Please

enter a commit message to explain why this merge is necessary, # especially if
it merges an updated upstream into a topic branch. # # Lines starting with '#'
will be ignored, and an empty message aborts # the commit.
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 23, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 17ca573
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kumsmrit kumsmrit self-assigned this Sep 29, 2025
Copy link

@kumsmrit kumsmrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. The changes look good, I have just added a minor comment.

@badmintoncryer
Copy link
Contributor Author

@kumsmrit Thank you for your review!! I've updated the error message.

kumsmrit
kumsmrit previously approved these changes Oct 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 9, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/integration-test-deployment.yml without workflows permission

@badmintoncryer
Copy link
Contributor Author

@kumsmrit Could you please approve again?

@mergify mergify bot dismissed kumsmrit’s stale review October 10, 2025 10:48

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 13, 2025
@mergify mergify bot merged commit ce9b3a8 into aws:main Oct 13, 2025
21 of 22 checks passed
@mergify mergify bot removed the queued label Oct 13, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2025
@badmintoncryer badmintoncryer deleted the desired-shard-metrics branch October 13, 2025 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants