Skip to content

feat(logs): support ADC regions for infrequent access log class #34999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2025
Merged

feat(logs): support ADC regions for infrequent access log class #34999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2f9717
remove unsupported regions for Infrequent Access
Jul 16, 2025
eefd38b
remove unsupported regions for Infrequent Access
Jul 16, 2025
4c58194
remove unsupported regions for Infrequent Access
Jul 16, 2025
898a633
remove log group unsupported regions test
Jul 17, 2025
6b1d7e0
remove region validation for LogGroupClass
Jul 17, 2025
58ad419
Merge branch 'main' into sennatb-chore-log-group
aemada-aws Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/aws-cdk-lib/aws-logs/lib/log-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { IProcessor, Transformer } from './transformer';
import * as cloudwatch from '../../aws-cloudwatch';
import * as iam from '../../aws-iam';
import * as kms from '../../aws-kms';
import { Annotations, Arn, ArnFormat, RemovalPolicy, Resource, Stack, Token, ValidationError } from '../../core';
import { Arn, ArnFormat, RemovalPolicy, Resource, Stack, Token, ValidationError } from '../../core';
import { addConstructMetadata } from '../../core/lib/metadata-resource';
import { propertyInjectable } from '../../core/lib/prop-injectable';

Expand Down Expand Up @@ -656,15 +656,6 @@ export class LogGroup extends LogGroupBase {
}

let logGroupClass = props.logGroupClass;
const stack = Stack.of(scope);
const logGroupClassUnsupportedRegions = [
'us-iso-west-1', // APA
'us-iso-east-1', // DCA
'us-isob-east-1', // LCK
];
if (logGroupClass !== undefined && !Token.isUnresolved(stack.region) && logGroupClassUnsupportedRegions.includes(stack.region)) {
Annotations.of(this).addWarningV2('@aws-cdk/aws-logs:propertyNotSupported', `The LogGroupClass property is not supported in the following regions: ${logGroupClassUnsupportedRegions}`);
}

const dataProtectionPolicy = props.dataProtectionPolicy?._bind(this);
const fieldIndexPolicies: any[] = [];
Expand Down
18 changes: 0 additions & 18 deletions packages/aws-cdk-lib/aws-logs/test/loggroup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,24 +164,6 @@ describe('log group', () => {
}, 0);
});

test('with log group class in a non-supported region', () => {
// GIVEN
const app = new App();
const stack = new Stack(app, 'TestStack', {
env: {
region: 'us-isob-east-1',
},
});

// WHEN
new LogGroup(stack, 'LogGroup', {
logGroupClass: LogGroupClass.STANDARD,
});

// THEN
Annotations.fromStack(stack).hasWarning('*', Match.stringLikeRegexp(/The LogGroupClass property is not supported in the following regions.+us-isob-east-1/));
});

test('will delete log group if asked to', () => {
// GIVEN
const stack = new Stack();
Expand Down
Loading