Skip to content

Conversation

@nburtsev
Copy link
Contributor

@nburtsev nburtsev commented Jul 17, 2025

Reason for this change

Routing through Cloud WAN Core Network

Description of changes

Added Core Network to RouterType enum, updated typeToParameter function, updated tests.

Describe any new or updated permissions being added

None

Description of how you validated changes

Updated and ran the tests. C

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 17, 2025 18:29
@github-actions github-actions bot added the p2 label Jul 17, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@nburtsev
Copy link
Contributor Author

Exemption Request
This PR adds additional element to existing Enum that's not mentioned in README, nor I believe this warrants updating integration tests.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 17, 2025
@nburtsev nburtsev force-pushed the support-cloud-wan-in-subnet-routes branch from 5ca5755 to 95977e2 Compare July 24, 2025 22:52
@nburtsev nburtsev force-pushed the support-cloud-wan-in-subnet-routes branch from 95977e2 to 6564838 Compare August 4, 2025 16:44
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6564838
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ozelalisen ozelalisen assigned ozelalisen and unassigned ozelalisen Sep 30, 2025
@Abogical Abogical self-assigned this Nov 4, 2025
@Abogical Abogical added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 4, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 4, 2025 13:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/analytics-metadata-updater.yml without workflows permission.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fba027b into aws:main Nov 4, 2025
19 of 20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants