fix(app-staging-synthesizer): custom bootstrap qualifier is not passed through to deployment role name #35118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d through to deployment role name
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Jul 30, 2025
iankhou
changed the title
iankhou
force-pushed
the
iankhou-app-staging-synth-qualifier
branch
from
313f4e4 to
8425c28
Compare
iankhou
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
Abogical
approved these changes
Aug 4, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #28195
Closes #28195
Reason for this change
When passing
bootstrapQualifierin props toAppStagingSynthesizer.defaultResources, the synthesizer would still use the default qualifier'hnb659fds'when looking for bootstrap roles.Description of changes
BootstraplessSynthesizeris modified to takequalifieras an optional argument (if not provided, default bootstrap qualifier 'hnb659fds' is used).The
bootstrapqualifieris passed toBootstraplessSynthesizer, which is called inAppStagingSynthesizer.defaultResources().These changes ensure that calls to
AppStagingSynthesizer.defaultResourcesusing thebootstrapQualifierwill use the qualifier in the deployment and CloudFormation execution roles instead of the default qualifier 'hnb659fds'.Describe any new or updated permissions being added
None.
Description of how you validated changes
Added unit tests for:
BootstraplessSynthesizer, which now optionally takesqualifieras an optionAppStagingSynthesizer, which passesqualifiertoBootstraplessSynthesizerTested by hand in a personal dev account.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license