Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #35427.

Reason for this change

AWS Cloudfront now supports for configuring IP address type for custom origins.

Description of changes

  • Add OriginIpAddressType enum
  • Add ipAddressType prop to HttpOriginProps

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 8, 2025 14:11
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 8, 2025
*
* If your origin uses both IPv4 and IPv6 protocols, you can choose dualstack to help optimize reliability.
*
* @default undefined - AWS Cloudfront default is IPv4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default value is described at management console.

スクリーンショット 2025-09-08 22 53 54

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 9, 2025
@kumsmrit kumsmrit self-assigned this Sep 19, 2025
kumsmrit
kumsmrit previously approved these changes Sep 19, 2025
Copy link

@kumsmrit kumsmrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kumsmrit’s stale review September 19, 2025 14:30

Pull request has been modified.

@badmintoncryer
Copy link
Contributor Author

@kumsmrit Thank you for your review! I've resolved all conflicts. Could you please approve this again?

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 196c7ae into aws:main Sep 25, 2025
19 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cloudfront-origins: add support for IPv6 origins

4 participants