feat: introduce reference interfaces, but don't require them yet #35651
Conversation
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
changed the title
rix0rrr
force-pushed
the
huijbers/only-expose-interfaces
branch
from
1a677e7 to
2f20046
Compare
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ The number of lines removed (11313) is greater than 1000
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
rix0rrr
force-pushed
the
huijbers/only-expose-interfaces
branch
2 times, most recently
from
346988c to
2fe140b
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ The number of lines removed (11313) is greater than 1000
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ The number of lines removed (11313) is greater than 1000
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
rix0rrr
force-pushed
the
huijbers/only-expose-interfaces
branch
from
2fe140b to
7e3cca7
Compare
rix0rrr
changed the base branch from
huijbers/patch-v2.114
to
huijbers/patch-v2.214
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
force-pushed
the
huijbers/only-expose-interfaces
branch
from
7e3cca7 to
020e6ba
Compare
This introduces the `IXxxRef` interfaces from #35032, without actually having the L2s extend them yet. This avoids introducing the implementation burden of them to the L2 interfaces, but does allow pre-implementation in advance of their requirement. Fix a bunch of build problems
rix0rrr
force-pushed
the
huijbers/only-expose-interfaces
branch
from
8ba2645 to
1ce2fcc
Compare
|
Subsumed by #35671 |
|
Comments on closed issues and PRs are hard for our team to see. |
2 participants
This introduces the
IXxxRefinterfaces from #35032, without actually having the L2s extend them yet.This avoids introducing the implementation burden of them to the L2 interfaces, but does allow pre-implementation in advance of their requirement.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license