Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Oct 2, 2025

Issue # (if applicable)

Closes #35656 .

Reason for this change

Missing storage types.

Description of changes

Add supported storage types to docs

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 2, 2025 11:11
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 2, 2025
@ozelalisen ozelalisen self-assigned this Oct 2, 2025
ozelalisen
ozelalisen previously approved these changes Oct 2, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@ozelalisen
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed ozelalisen’s stale review October 2, 2025 14:20

Pull request has been modified.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 2, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 2, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 2, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 2, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 2, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 2, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 2, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@ozelalisen ozelalisen merged commit 2748149 into aws:main Oct 3, 2025
24 of 25 checks passed
@mergify mergify bot removed the queued label Oct 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(rds): DatabaseInstance construct documentation does not show latest storage types

2 participants