-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(lambda-nodejs): bump bun to 1.2.23 for ARM64 support #35702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-nodejs): bump bun to 1.2.23 for ARM64 support #35702
Conversation
Latest version as of current date. Fixes missing package for 1.1.30 when building on graviton instances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
Exemption request: We don't need to change tests here. In fact, we don't want to. We want to make sure it still passes any existing tests. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Latest version as of current date.
Fixes missing package for 1.1.30 when building on graviton instances
Issue # (if applicable)
Closes #35534.
Reason for this change
The aws-lambda-nodejs construct fails Docker bundling on ARM64 architectures (AWS Graviton instances) because bun@1.1.30 is missing the required
@oven/bun-linux-aarch64package. This causes npm to fail when trying to install bun during the Docker build process, with the error:Description of changes
Bumped bun from version 1.1.30 to 1.2.23 in
packages/aws-cdk-lib/aws-lambda-nodejs/lib/Dockerfile.This addresses the issue because bun@1.2.23 includes proper ARM64 support via optional dependencies:
@oven/bun-linux-aarch64@oven/bun-linux-aarch64-muslWhy this approach: This is a simpler solution than alternatives (such as switching to the curl-based bun installer) because:
Alternatives considered:
Describe any new or updated permissions being added
None. This change only updates a package version.
Description of how you validated changes
Verified that bun@1.2.23 includes the required ARM64 packages:
$ npm view bun@1.2.23 optionalDependencies { "@oven/bun-linux-aarch64": "1.2.23", "@oven/bun-linux-aarch64-musl": "1.2.23", ... }Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license