Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Oct 8, 2025

Reverts #35359

Mergify merged it, but integ tests failed.

@iankhou iankhou had a problem deploying to deployment-integ-test October 8, 2025 19:54 — with GitHub Actions Failure
@github-actions github-actions bot added the p2 label Oct 8, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 8, 2025 19:54
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 8, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@iankhou iankhou changed the title Revert "feat(logs): add parameter to allow metric filter on transformed logs" revert: feat(logs): add parameter to allow metric filter on transformed logs Oct 8, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 8, 2025 19:59

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@iankhou iankhou closed this Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2025
@iankhou
Copy link
Contributor Author

iankhou commented Oct 8, 2025

The PR to be reverted is fine. It failed on a new workflow, which has never passed.

@iankhou iankhou deleted the revert-35359-aws-logs-add-parameter-to-allow-metric-filter-on-transformed-logs branch October 8, 2025 21:36
@iankhou iankhou had a problem deploying to deployment-integ-test October 10, 2025 14:12 — with GitHub Actions Failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants