Skip to content

Conversation

@kg-aws
Copy link
Contributor

@kg-aws kg-aws commented Oct 13, 2025

Issue # (if applicable)

Closes #27762

Reason for this change

Description of changes

This change introduces the forceNewDeployment feature for ECS services, which allows users to trigger a new deployment even when there are no service definition changes.

CFN public doc: https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-ecs-service-forcenewdeployment.html

Describe any new or updated permissions being added

Description of how you validated changes

  • Added unit test
  • Ran integ-test locally

Note: I don't think we can add an integ-test for forceNewDeployment set to true as function generates a new nonce with each run which results in new CFN template.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Oct 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 13, 2025 13:31
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@kg-aws kg-aws changed the title feat(ecs): Add forceNewDeployment feature for ecs service feat(ecs): add forceNewDeployment feature for ecs service Oct 13, 2025
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Oct 13, 2025
@kg-aws kg-aws marked this pull request as ready for review October 13, 2025 15:20
@kg-aws kg-aws force-pushed the ecs_force_new_deployment branch from 1309d8c to f4d8e63 Compare October 13, 2025 15:26
@kg-aws
Copy link
Contributor Author

kg-aws commented Oct 13, 2025

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Exemption Request: The function forceNewDeployment when set to true generates new nonce which generates a diff in the CFN integ-test template. If there is some otherway to suppress the diff, I am happy add an integ-test.

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-ecs: FargateServiceProps Missing Field forceNewDeployment?

2 participants