Skip to content

Conversation

@sushilk123
Copy link

Issue # (if applicable)

Fixes #35524

Reason for this change

The IAttributeGroup interface was missing an attributes property, making it impossible to access attribute group attributes when using fromAttributeGroupArn().

Description of changes

  • Added attributes property to IAttributeGroup interface
  • Updated AttributeGroupBase abstract class to include the property
  • Modified fromAttributeGroupArn to expose attributes (empty object for imported resources)
  • Updated main AttributeGroup class to properly expose constructor attributes
  • Added test coverage for the new functionality

Description of how you validated changes

  • Added unit test to verify attributes property access
  • Verified interface compliance across all implementations

Checklist

…eGroup interface

Adds the attributes property to the IAttributeGroup interface to allow access
to attribute group attributes when using fromAttributeGroupArn.

Fixes aws#35524
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 15, 2025 12:58
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

- Added README documentation showing attributes property usage
- Updated integration test to demonstrate attributes access
- Updated integration test snapshot with new output
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 15, 2025 13:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@sushilk123
Copy link
Author

Hi, could some please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-servicecatalogappregistry-alpha): Add retrieving of attributes from construct

3 participants