feat(kinesisfirehose): support iceberg destination #35761
+35,218
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Oct 16, 2025
tmokmss
reviewed
Oct 22, 2025
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Show resolved
Hide resolved
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-kinesisfirehose/lib/iceberg-destination.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-kinesisfirehose/lib/iceberg-destination.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-kinesisfirehose/lib/iceberg-destination.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-kinesisfirehose/lib/iceberg-destination.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Show resolved
Hide resolved
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…ub.com:Konippi/aws-cdk into support-iceberg-destination-in-kinesisfirehose
tmokmss
reviewed
Nov 3, 2025
Contributor
tmokmss
left a comment
tmokmss
left a comment
There was a problem hiding this comment.
The L2 API looks good to me. I left comments mostly on the integ-test part. Also, can you resolve the past conversations that are already fixed? (because apparently I don't have permission to do that.) Thanks!
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/integ.iceberg-destination.ts
Show resolved
Hide resolved
aws-cdk-automation
added
the
pr/needs-community-review
…ub.com:Konippi/aws-cdk into support-iceberg-destination-in-kinesisfirehose
…tination-in-kinesisfirehose
mazyu36
reviewed
Nov 6, 2025
Contributor
mazyu36
left a comment
mazyu36
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
I've add some minor comments.
aws-cdk-automation
added
pr/needs-maintainer-review
tmokmss
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33666.
Reason for this change
Firehose supports the destination settings for Apache Iceberg Table.
https://docs.aws.amazon.com/firehose/latest/dev/apache-iceberg-destination.html
But at the present, L2 Construct does not support it.
Description of changes
This PR adds a new
IcebergDestinationto theaws-kinesisfirehosemodule that implements theIDestinationinterface.Describe any new or updated permissions being added
Description of how you validated changes
Unit tests and integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license